From 58aecc9d860a18767aa51d0d94793057e1aa57e2 Mon Sep 17 00:00:00 2001 From: xengineering Date: Mon, 3 Jul 2023 14:03:19 +0200 Subject: Remove intended breakage This removes the injected broken code which made the race condition reproducible. --- xmpp/stream_pair.go | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/xmpp/stream_pair.go b/xmpp/stream_pair.go index 2feea6b..87df86a 100644 --- a/xmpp/stream_pair.go +++ b/xmpp/stream_pair.go @@ -13,13 +13,13 @@ func runStreamPair(s *session) { for { select { -// case data := <-s.in: -// switch data.(type) { -// case SessionShouldDisconnect: -// return -// default: -// log.Printf("Unknown data '%d'!\n", data) -// } + case data := <-s.in: + switch data.(type) { + case SessionShouldDisconnect: + return + default: + log.Printf("Unknown data '%d'!\n", data) + } case t := <-s.rx: err := buf.add(t) if err != nil { @@ -66,13 +66,13 @@ func openStream(s *session) xml.EndElement { func syncStreams(s *session) { for { select { -// case data := <-s.in: -// switch data.(type) { -// case SessionShouldDisconnect: -// return -// default: -// log.Printf("Unhandled data '%d' during stream sync!\n", data) -// } + case data := <-s.in: + switch data.(type) { + case SessionShouldDisconnect: + return + default: + log.Printf("Unhandled data '%d' during stream sync!\n", data) + } case t := <-s.rx: switch token := t.(type) { case xml.StartElement: -- cgit v1.2.3-70-g09d2