soundbox-go/soundbox, branch v0.1.5Go library to interface with soundbox deviceshttps://cgit.xengineering.eu/soundbox-go/atom?h=v0.1.52024-11-29T09:16:57ZRefactor streamContext()2024-11-29T09:16:57Zxegineeringme@xegineering.eu2024-11-29T09:16:57Zurn:sha1:f5f0d12b697e71e67a403791c1b93ffdf61e272a
This avoids an unnecessary additional for loop.
Handle internal error correctly2024-11-29T09:06:01Zxegineeringme@xegineering.eu2024-11-29T09:06:01Zurn:sha1:97af30e8fee2274a437a13d8c2c19e4bfe29ddeeFix variable buffer size2024-11-29T08:16:57Zxegineeringme@xegineering.eu2024-11-29T08:16:57Zurn:sha1:49dc5ae3c12f2c696302171b54b130d94dea05e0
The switch to `io.Copy()` to pump the data to the soundbox devices
removed the control over the buffer size of this copy action.
While for generic copy actions it is even an advantage when a big buffer
is used this is a problem for the soundbox use case. A big buffer used
during copy means that the first soundbox device gets audio data
significantly earlier than the later ones since `io.MultiWriter()` works
sequentially.
Thus this commit switches to `io.CopyBuffer()` where a buffer has to
provided. For that purpose the same buffer size is used as before the
refactoring to use `io.Copy()`.
Replace custom code by io package functions2024-11-28T21:44:28Zxegineeringme@xegineering.eu2024-11-28T21:44:28Zurn:sha1:99031596efbcf004188217d2a9e53ac5ce33b511
This makes use of two functions from this package:
- io.Copy()
- io.MultiWriter()
`io.Copy()` is used to move the data from whatever reader is provided.
`io.Multiwriter()` solves the issue that we need to stream to multiple
network connections at the same time (one for each soundbox).
Handle read error after processing buffer2024-11-27T20:55:40Zxegineeringme@xegineering.eu2024-11-27T20:55:40Zurn:sha1:bb84332ef7ca114f0c608bbea7f11451f010a831
This is recommended by the Go standard library. One reason is that a
Reader might deliver the last couple of bytes together with the EOF
error. This is only handled correctly if the returned bytes are
processed first and the error is handled later.
[1]: https://pkg.go.dev/io#Reader
Introduce io.Reader-based streamContext()2024-11-27T20:38:16Zxegineeringme@xegineering.eu2024-11-27T20:29:39Zurn:sha1:6b7da29eea100b92659a3f1f5df6958ebad544c8
This prepares the switch to adding more sources than web URLs.
Everything providing an io.Reader can then simply use this internal
function in the background to avoid code duplication.
Fix streaming only via first interface candidate2024-11-17T11:48:00Zxegineeringme@xegineering.eu2024-11-17T11:45:35Zurn:sha1:d4cf5ed8e38d1e5d0b8110e8959e002c216f073fAvoid unnecessary variable for args2024-11-10T14:54:59Zxegineeringme@xegineering.eu2024-11-10T14:54:59Zurn:sha1:93d3ce8ca7d335fb15da64981321f82891c1493cUse Go code for output network stream2024-11-10T14:53:44Zxegineeringme@xegineering.eu2024-11-08T19:56:56Zurn:sha1:36a2fda37e837bc39c88a2fa38678b0f3bded041
Calling the external program `ffmpeg` should be avoided completely in
the future to make soundbox-go a pure Go code base. `ffmpeg` provides
the following functionality to soundbox-go:
- web radio input stream transport
- re-encoding of the audio stream
- output stream transport to soundbox devices
The last part should be replaced with this commit as a first step.
Rename cmd to args2024-11-08T19:35:24Zxegineeringme@xegineering.eu2024-11-08T19:35:24Zurn:sha1:e30a1b0768d35ec70e5d2c00e6ae87c0f267b881
This variable only contains the arguments for the called program. Thus
it should be named like this.
Change module name and restructure content2024-10-31T21:10:36Zxegineeringme@xegineering.eu2024-10-31T21:10:36Zurn:sha1:79eeb90079e417f0a9d040c1de8f3278c628810f
The repository names for soundbox are named as below:
- app: soundbox-app
- Go library module: soundbox-go
- Device: soundbox
The Go module names were:
- app: xengineering.eu/soundbox/app
- Go library module: xengineering.eu/soundbox
This does not make clear which module is related to which repository
since the names are different. Thus it should be changed to:
- app: xengineering.eu/soundbox-app
- Go library module: xengineering.eu/soundbox-go
The import statement for the library is then:
import "xengineering.eu/soundbox-go/soundbox"
This is a bit longer but it keeps the property that the library is
referenced inside the code by the simple name `soundbox`.
Make soundbox package top-level2024-10-01T20:20:47Zxegineeringme@xegineering.eu2024-10-01T20:20:47Zurn:sha1:3fc713ccfcc96738d981a97647a84a6cb6bbec04
It is not expected that this library will be so big that multiple
packages make sense. Thus it should start only with the main package.
Add minimal soundbox Go package2024-10-01T19:44:47Zxegineeringme@xegineering.eu2024-10-01T19:44:47Zurn:sha1:c472e5c7dee2e1cb16e297b23726a714521e8e0b
This only adds the `Soundbox` struct type which has a `net.HardwareAddr`
to identify it together with a constructor and a unit test.